Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type error in apollo-server-core because @types/fs-capacitor have been removed #7060

Closed
Yogu opened this issue Oct 20, 2022 · 2 comments
Closed

Comments

@Yogu
Copy link

Yogu commented Oct 20, 2022

DefinitelyTyped/DefinitelyTyped#62785 removed the types for fs-capacitor and replaced it with a stub. apollo-server-core uses https://github.com/apollographql/graphql-upload, a fork of graphql-upload, which specifies "*" for this package. Therefore, starting yesterday, using apollo-server-core 2 causes a type error.

I created a pull request that fixes this apollographql/graphql-upload#3. I'm opening an issue here, too, because I'm not sure how closely watched that fork is.

@glasser
Copy link
Member

glasser commented Oct 20, 2022

Thanks, this is fixed in v2.26.1

Note that Apollo Server 2 has been de facto deprecated since July 2021; we will shortly be putting our deprecation/end-of-life policy in writing. We highly recommend upgrading to Apollo Server 4 as soon as possible. (The graphql-upload package which caused this issue and which has been removed from AS3 is particularly problematic, as using it in AS2 without security features added in AS3 is likely to create a major security hole in your app.)

@glasser glasser closed this as completed Oct 20, 2022
@Yogu
Copy link
Author

Yogu commented Oct 21, 2022

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants