apollo-engine-reporting: privateHeaders need to be specified in lower-case #2273
Comments
abernix
added a commit
that referenced
this issue
Feb 6, 2019
…cumented. The documentation for `privateHeaders`[[0]] suggests that it is case-insensitive. While that statement is true, and the incoming header is lower-cased before checking it against the `privateHeaders` configuration, it assumed that the headers in the `privateHeaders` object were specified in lower-case. This changes the comparison to lower-case both sides prior to determining equality. [0]: https://github.com/apollographql/apollo-server/blob/abb8dc58/packages/apollo-engine-reporting/src/agent.ts#L67-L70 Fixes: #2273
abernix
added a commit
that referenced
this issue
Feb 6, 2019
…cumented. The documentation for `privateHeaders`[[0]] suggests that it is case-insensitive. While that statement is true, and the incoming header is lower-cased before checking it against the `privateHeaders` configuration, it assumed that the headers in the `privateHeaders` object were specified in lower-case. This changes the comparison to lower-case both sides prior to determining equality. [0]: https://github.com/apollographql/apollo-server/blob/abb8dc58/packages/apollo-engine-reporting/src/agent.ts#L67-L70 Fixes: #2273
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The privateHeaders option to apollo-engine-reporting is documented as being case-insensitive (appropriate for HTTP headers), and it does work with all casings of actual received headers, but the current implementation accidentally assumes that the header names specified in the privateHeaders option are already lower-case. They should be allowed to be in any case.
The text was updated successfully, but these errors were encountered: