Updating the lambda handler to handle invalid JSON bodies instead of …

…throwing errors
apollographql · Jul 30, 2019 · babc688 · babc688
1 parent 293e28d
commit babc688
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/packages/apollo-server-integration-testsuite/src/index.ts b/packages/apollo-server-integration-testsuite/src/index.ts
@@ -240,6 +240,17 @@ export default (createApp: CreateAppFunc, destroyApp?: DestroyAppFunc) => {
         });
       });
 
+      it('throws an error if POST body contains invalid JSON', async () => {
+        app = await createApp();
+        const req = request(app)
+          .post('/graphql')
+          .send('**_NOT_JSON_**');
+        return req.then(res => {
+          expect(res.status).toBeGreaterThanOrEqual(400);
+          expect(res.status).toBeLessThanOrEqual(500);
+        });
+      });
+
       it('throws an error if GET query is missing', async () => {
         app = await createApp();
         const req = request(app).get(`/graphql`);

diff --git a/packages/apollo-server-lambda/src/lambdaApollo.ts b/packages/apollo-server-lambda/src/lambdaApollo.ts
@@ -39,13 +39,23 @@ export function graphqlLambda(
         statusCode: 500,
       });
     }
+
+    let query: any = event.queryStringParameters;
+    if (event.httpMethod === 'POST' && event.body) {
+      try {
+        query = JSON.parse(event.body);
+      } catch (error) {
+        return callback(null, {
+          body: 'Error parsing JSON POST body',
+          statusCode: 415,
+        });
+      }
+    }
+
     runHttpQuery([event, context], {
       method: event.httpMethod,
       options: options,
-      query:
-        event.httpMethod === 'POST' && event.body
-          ? JSON.parse(event.body)
-          : event.queryStringParameters,
+      query: query,
       request: {
         url: event.path,
         method: event.httpMethod,