-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Factor out runQuery's use of logFunction into an extension
This requires a slightly newer graphql-extensions beta which has more arguments to requestDidStart. Also make it ok to not pass logFunction to formatApolloErrors, and make sure custom fieldResolvers continue to work with extensions (by upgrading the dependency and fixing a logic bug). The custom fieldResolvers fix means that we now unconditionally put the extension stack on the GraphQL context, which means that the context can no longer be (say) a string. I changed a test that expected string contexts to work. You couldn't use a string for a context when using extensions before, so this isn't that big of a change.
- Loading branch information
Showing
5 changed files
with
113 additions
and
60 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters