catching circular reference errors, adding test

packages/apollo-engine-reporting/src/__tests__/extension.test.ts

@@ -271,6 +271,19 @@ describe('variableJson output for sendVariableValues transform: custom function
   });
 });
 
+describe('Catch circular reference error during JSON.stringify', () => {
+  const circularReference = {};
+  circularReference['this'] = circularReference;
+
+  const circularVariables = {
+    bad: circularReference,
+  };
+
+  expect(
+    makeTraceDetails(circularVariables, { all: true }).variablesJson['bad'],
+  ).toEqual(JSON.stringify('[Unable to convert value to JSON]'));
+});
+
 function makeTestHTTP(): Trace.HTTP {
   return new Trace.HTTP({
     method: Trace.HTTP.Method.UNKNOWN,

packages/apollo-engine-reporting/src/extension.ts

@@ -462,9 +462,15 @@ export function makeTraceDetails(
       } catch (e) {
         if (
           e.name === 'TypeError' &&
-          e.message === 'Converting circular structure to JSON'
+          (e.message === 'cyclic object value' || // firefox
+          e.message === 'Converting circular structure to JSON' || // chrome, opera
+            e.message === 'Circular reference in value argument not supported') // edge
+          // May be unnecessary to check against each browser
+          // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value#Message
         ) {
-          details.variablesJson![name] = JSON.stringify(e.message);
+          details.variablesJson![name] = JSON.stringify(
+            '[Unable to convert value to JSON]',
+          );
         } else {
           // Re-throw when it doesn't meet our expectation so we don't
           // inadvertently swallow anything as a "cycle error" when its not.