Fix regression caused by #3614 when using APQ with Graph Manager repo…

…rting.

The fix in #3614 changed behavior which was not surfacing errors to the
extensions and request pipeline plugins when those errors occurred during
APQ negotiation.

However, it failed to consider - nor were there any tests - which ensured
that the `apollo-engine-reporting`'s mechanism didn't receive an error
earlier in the request pipeline than previously allowed.

This applies a fix which special-cases the APQ error in this case, and
avoids reporting it to Apollo Graph Manager (which is the same behavior as
before).

packages/apollo-engine-reporting/package.json

@@ -15,6 +15,7 @@
     "apollo-graphql": "^0.3.4",
     "apollo-server-caching": "file:../apollo-server-caching",
     "apollo-server-env": "file:../apollo-server-env",
+    "apollo-server-errors": "file:../apollo-server-errors",
     "apollo-server-types": "file:../apollo-server-types",
     "async-retry": "^1.2.1",
     "graphql-extensions": "file:../graphql-extensions"

packages/apollo-engine-reporting/src/treeBuilder.ts

@@ -5,6 +5,7 @@ import {
   responsePathAsArray,
 } from 'graphql';
 import { Trace, google } from 'apollo-engine-reporting-protobuf';
+import { PersistedQueryNotFoundError } from 'apollo-server-errors';
 
 function internalError(message: string) {
   return new Error(`[internal apollo-server error] ${message}`);
@@ -77,6 +78,10 @@ export class EngineReportingTreeBuilder {
 
   public didEncounterErrors(errors: GraphQLError[]) {
     errors.forEach(err => {
+      if (err instanceof PersistedQueryNotFoundError) {
+        return;
+      }
+
       // This is an error from a federated service. We will already be reporting
       // it in the nested Trace in the query plan.
       //

packages/apollo-engine-reporting/tsconfig.json

@@ -8,6 +8,7 @@
   "exclude": ["**/__tests__", "**/__mocks__"],
   "references": [
     { "path": "../graphql-extensions" },
+    { "path": "../apollo-server-errors" },
     { "path": "../apollo-server-types" },
   ]
 }