Skip to content

Commit

Permalink
Update GraphQL Playground to fix tab colors when `theme: "light… (#2989)
Browse files Browse the repository at this point in the history
* Update GraphQL Playground to fix tab colors when `theme: "light"`.

Fixes #2979

* Add CHANGELOG.md
  • Loading branch information
abernix authored Jul 4, 2019
1 parent fe35308 commit 034fdea
Show file tree
Hide file tree
Showing 12 changed files with 81 additions and 24 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ The version headers in this history reflect the versions of Apollo Server itself
- `apollo-engine-reporting`: **BEHAVIOR CHANGE**: If the error returned from the `engine.rewriteError` hook has an `extensions` property, that property will be used instead of the original error's extensions. Document that changes to most other `GraphQLError` fields by `engine.rewriteError` are ignored. [PR #2932](https://github.com/apollographql/apollo-server/pull/2932)
- `apollo-engine-reporting`: **BEHAVIOR CHANGE**: The `engine.maskErrorDetails` option, deprecated by `engine.rewriteError` in v2.5.0, now behaves a bit more like the new option: while all error messages will be redacted, they will still show up on the appropriate nodes in a trace. [PR #2932](https://github.com/apollographql/apollo-server/pull/2932)
- `apollo-engine-reporting`: **BEHAVIOR CHANGE**: By default, send no GraphQL variable values to Apollo's servers instead of sending all variable values. Adding the new EngineReportingOption `sendVariableValues` to send some or all variable values, possibly after transforming them. This replaces the `privateVariables` option, which is now deprecated. [PR #2931](https://github.com/apollographql/apollo-server/pull/2931)
- Update `graphql-playground` to resolve incorrect background color on tabs when using the `light` theme. [PR #2989](https://github.com/apollographql/apollo-server/pull/2989) [Issue #2979](https://github.com/apollographql/apollo-server/issues/2979)
- `apollo-server-express`, `apollo-server-koa`: A new `getMiddleware` method, which accepts the same parameters as `applyMiddleware` with the exception of the `app`, has been added. This allows implementors to obtain the composed middleware and "`use`" it within an existing `app`. This was previously only possible by passing an `app` to `applyMiddleware` or reaching into Apollo Server internals, but `getMiddleware` should allow a more natural method and will hopefully resolve many issues raised around the previous pattern. [PR #2435](https://github.com/apollographql/apollo-server/pull/2435)

> Note: In order to keep shipping all GraphQL variable values to Apollo Engine, pass in the option:
Expand Down
84 changes: 70 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/apollo-server-azure-functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"node": ">=6"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"apollo-server-core": "file:../apollo-server-core",
"apollo-server-env": "file:../apollo-server-env",
"graphql-tools": "^4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-cloud-functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"node": ">=6"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"apollo-server-core": "file:../apollo-server-core",
"apollo-server-env": "file:../apollo-server-env",
"graphql-tools": "^4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@apollographql/apollo-tools": "^0.3.6",
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"@types/ws": "^6.0.0",
"apollo-cache-control": "file:../apollo-cache-control",
"apollo-datasource": "file:../apollo-datasource",
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-core/src/playground.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export {
// This specifies the version of `graphql-playground-react` that will be served
// from `graphql-playground-html`. It's passed to ``graphql-playground-html`'s
// renderPlaygroundPage` via the integration packages' playground configuration.
const playgroundVersion = '1.7.26';
const playgroundVersion = '1.7.28';

// https://stackoverflow.com/a/51365037
type RecursivePartial<T> = {
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"node": ">=6"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"@types/accepts": "^1.3.5",
"@types/body-parser": "1.17.0",
"@types/cors": "^2.8.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-fastify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"node": ">=6"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"apollo-server-core": "file:../apollo-server-core",
"fastify-accepts": "^0.5.0",
"fastify-cors": "^0.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-hapi/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"node": ">=8"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"accept": "^3.0.2",
"apollo-server-core": "file:../apollo-server-core",
"boom": "^7.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-koa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"node": ">=6"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"@koa/cors": "^2.2.1",
"@types/accepts": "^1.3.5",
"@types/cors": "^2.8.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-lambda/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"node": ">=6"
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"apollo-server-core": "file:../apollo-server-core",
"apollo-server-env": "file:../apollo-server-env",
"graphql-tools": "^4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-micro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"homepage": "https://github.com/apollographql/apollo-server#readme",
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.20",
"@apollographql/graphql-playground-html": "1.6.23",
"accept": "^3.0.2",
"apollo-server-core": "file:../apollo-server-core",
"micro": "^9.3.2"
Expand Down

0 comments on commit 034fdea

Please sign in to comment.