fix(parser,compiler): fix string serialization bugs found by fuzzing #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a block string, the first line does not affect the common
indent, as it would normally have no indent at all. But when
serializing a string to a block string, the first line *is* important,
namely for a single-line string that starts with whitespace.
Assume a text like this:
```
Starts with "spaces"
```
If we skip the first line, the common indent is detected as 0,
producing this output:
```graphql
"""
Starts with "spaces"
"""
```
Now when reparsing, the common indent is detected as 4, and you get
back:
```
Starts with "spaces"
```
which is wrong.
Backslash is not special in block strings except in the exact sequence `\"""`. So if you write `\\"""`, that sequence should still be treated as the escape sequence for `"""`. This patch fixes that. Previously, we would return to the BlockStringLiteral state on the second `\`, and interpret the `"""` as the end of the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes:
\\"""in a block string should be lexed as\followed by\""", previously the first backslash escaped the second backslash and caused the"""to be interpreted as the end of the string.