Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

fix: prevent dedup crash #988

Merged
merged 3 commits into from
Mar 14, 2019
Merged

fix: prevent dedup crash #988

merged 3 commits into from
Mar 14, 2019

Conversation

JoviDeCroock
Copy link
Contributor

@JoviDeCroock JoviDeCroock commented Mar 14, 2019

fixes: #986

Verified

This commit was signed with the committer’s verified signature.
addaleax Anna Henningsen

Verified

This commit was signed with the committer’s verified signature.
jasnell James M Snell
@codecov-io
Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #988 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          22       22           
  Lines        1020     1020           
  Branches      103       92   -11     
=======================================
  Hits          971      971           
  Misses         44       44           
  Partials        5        5
Impacted Files Coverage Δ
packages/apollo-link-dedup/src/dedupLink.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfdbad...b781991. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
danielleadams Danielle Adams
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - thanks @JoviDeCroock!

@hwillson hwillson merged commit a42114b into master Mar 14, 2019
@hwillson hwillson deleted the fix/dedup_crash branch March 14, 2019 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'delete' of undefined
3 participants