You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbaxleyiii I added sourcemap support for jest coverage and rollup builds(wasn't picking up the tsc sourcemaps). Tested with example from #248, so should work 🙏. We should definitely think about moving to RxJs if they have addressed the bundle size issues
apollo-link's bundle now emits Observable = Observable && Observable.hasOwnProperty('default') ? Observable['default'] : Observable; and the index contains import Observable from 'zen-observable'; , so we should be set
@JounQin Good point! We shouldn't be forcing a specific tsconfig.json. I think the best way forward is to either switch to RxJs or write an implementation of zen-observable in typescript, since the * as imports break js builds and a direct import necessitates the allowSyntheticDefaultImports. Please take a look at #515. If you think there is a better way forward please share.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
cc @evans