[Codegen] Allow default value for non nullable variables #2760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2686. This allow to omit the variable value if it has a defaultValue (even if the variable is non-nullable)
will generate
I'm opening this mainly for reference. That's a potentially relatively seriously invasive/breaking change that has bitten us in the past (#2744, #2742). Given that it can be worked around relatively easily by passing the defaultValue in Kotlin code, and unless there are other important use cases I'm missing, this PR will only be merged for the next major version