Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update downloading-schema.md #347

Merged
merged 1 commit into from
Aug 12, 2018

Conversation

raudabaugh
Copy link
Contributor

Passing the schema.json argument to Apollo CLI results in this error:

TypeError: Cannot read property 'trim' of undefined
    at Object.parse (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/lib/commands/schema/download.js:52:57)
    at Parser._flags (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/node_modules/@oclif/parser/lib/parse.js:149:49)
    at Parser.parse (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/node_modules/@oclif/parser/lib/parse.js:112:28)
    at Object.parse (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/node_modules/@oclif/parser/lib/index.js:25:27)
    at SchemaDownload.parse (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/node_modules/@oclif/command/lib/command.js:68:41)
    at SchemaDownload.run (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/lib/commands/schema/download.js:13:38)
    at SchemaDownload._run (~/.nvm/versions/node/v8.11.2/lib/node_modules/apollo/node_modules/@oclif/command/lib/command.js:29:31)

@ghost ghost added the docs Focuses on documentation changes label Aug 10, 2018
@apollo-cla
Copy link

@raudabaugh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@raudabaugh
Copy link
Contributor Author

relevant: apollographql/rover#528

@Camji55
Copy link
Contributor

Camji55 commented Aug 11, 2018

@raudabaugh Try closing this request and re-opening to run the CI build again. It shouldn't have failed with your change, and I want to see if the same result occurs.

@Camji55
Copy link
Contributor

Camji55 commented Aug 11, 2018

@martijnwalraven Are you able to run a manual CI Test on the current repo? This pull request failed, and shouldn't have with the change it made.

@martijnwalraven martijnwalraven merged commit 9f9d492 into apollographql:master Aug 12, 2018
@martijnwalraven
Copy link
Contributor

It passed after I restarted it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants