Make SOCKS proxy support public #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-ios-docs pending review.Visit the deploys page to approve it
|
calvincestari
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
This looks good, thanks for the contribution @tahirmt.
Added tests for WebSocketTransport but I couldn't find create tests of WebSocket due to how it is written.
Correct - some parts of the networking stack are difficult to work with at the moment, part of the motivation for the work to be done in 2.0.
|
Merging - ignore the test failure, I understand what's going wrong and will fix it. tl;dr - it's a CI/test configuration, not incorrect logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2788
This was originally added in #1108 but removed when
Starscreamwas removed but for debugging tools like Charles, it is very useful to be able to see the web socket traffic.I made the implementation non-breaking by using the sam approach of
SOCKSProxyableprotocol from #1108.Added tests for
WebSocketTransportbut I couldn't find create tests ofWebSocketdue to how it is written.