Check type name conflicts in SelectionSet #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding validation to check for type name conflicts in selection set fields based on pluralization.
✅ Deploy Preview for apollo-ios-docs canceled.
|
BobaFetters
commented
May 12, 2023
AnthonyMDev
previously requested changes
May 12, 2023
- Moved extension methods from `SelectionSetTemplate` to new `IR+Formatting.swift` file - Updated algorithm to loop through and check nested fragments for merged field conflicts - Added field to `typeNameConflict` error to be able to display the operation/fragment that contains the error - Minor code cleanup
BobaFetters
dismissed
AnthonyMDev’s stale review
Feedback addressed in latest update to PR
- Added a few more tests - Added a troubleshooting page to further explain this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validation to check for type name conflicts in selection set fields based on pluralization.
Closes #2850