Move Object Type to DataDict #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
approved these changes
Feb 1, 2023
...s/AnimalKingdomAPI/AnimalKingdomAPI/Sources/Operations/Queries/AllAnimalsQuery.graphql.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
_objectTypefield from theSelectionSetprotocol to theDataDict.This is in preparation for #2551, which will require the object type to be manually set by the generated initializers (instead of computed from the Schema config and__typename).This PR also includes some refactoring of other API surfaces that will introduce minor breaking changes (mostly around APIs that are intended to be
internal, but must bepublicfor generated code consumption). Those changes are:AnySelectionSetcompletelySelectionSet.init(unsafeData: variables).DataDictinitializerinternal