Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing InstallCLI plugin product #2683

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

calvincestari
Copy link
Member

Fixes #2682

The .plugin product is missing, effectively 'hiding' the new plugin from SPM and Xcode.

  • adds the missing .plugin product
  • uses a custom path in the target definition so the menu name can get a space between the two words

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 9f636bf
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/637be7421d29e400090b6949

@calvincestari calvincestari mentioned this pull request Nov 21, 2022
7 tasks
@calvincestari calvincestari merged commit 715b053 into main Nov 21, 2022
@calvincestari calvincestari deleted the fix/install-cli-plugin branch November 21, 2022 21:52
@cwjames19
Copy link

@calvincestari After installing v1.0.5 with SPM and Xcode, I still don't see the "Install CLI" option in the menu after I right-click "Apollo" under package dependencies as described in the CLI installation docs.

I've tried selecting different combinations of package products when adding the Apollo package dependency but the result is always the same. I can see the file Apollo/Plugins/InstallCLI/InstallCLIPluginCommand is present, though.

@calvincestari
Copy link
Member Author

That screenshot in the docs is misleading; you need to right-click on your project, not the dependency. It looks like the dependency in the screenshot because of what the name is. I think that screenshot was taken while working in Apollo iOS and not a sample project. I'll get the screenshot updated.

See below:
Screen Shot 2022-12-14 at 9 58 06 PM

@cwjames19
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InstallCLI plugin is missing
2 participants