feat: Add support for .none module type - Part 1: File Templates
#2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
calvincestari
commented
Mar 31, 2022
calvincestari
commented
Mar 31, 2022
Sources/ApolloCodegenLib/Templates/ImportStatementTemplate.swift
Outdated
Show resolved
Hide resolved
calvincestari
commented
Mar 31, 2022
calvincestari
commented
Mar 31, 2022
Tests/ApolloCodegenTests/CodeGeneration/FileGenerators/SchemaModuleFileGeneratorTests.swift
Show resolved
Hide resolved
calvincestari
commented
Mar 31, 2022
Tests/ApolloCodegenTests/CodeGeneration/Templates/SwiftPackageManagerModuleTemplateTests.swift
Show resolved
Hide resolved
AnthonyMDev
approved these changes
Apr 1, 2022
|
|
||
| func render() -> String { | ||
| var target: TemplateTarget { .operationFile } |
There was a problem hiding this comment.
If a fragment is being shared across operations and those operations are in separate modules, the Fragment would need to be include in the schema module. We probably need to put some more thought into this.
Sources/ApolloCodegenLib/Templates/ImportStatementTemplate.swift
Outdated
Show resolved
Hide resolved
…s to reuse function to render subject
…2234) * Adapt EnumFileGenerator to FileGenerator * Adapt ObjectFileGenerator to FileGenerator * Adapt InterfaceFileGenerator to FileGenerator * Adapt FragmentFileGenerator to FileGenerator * Adapt InputObjectFileGenerator to FileGenerator * Adapt OperationFileGenerator to FileGenerator * Adapt SchemaFileGenerator to FileGenerator * Adapt UnionFileGenerator to FileGenerator * Add Equatable conformance to OperationDefinition * Remove render function from TemplateRenderer protocol - only in extension * Rename MockTemplate to MockFileTemplate * Add FileGenerator protocol * Move path resolver logic into FileGenerator * Add FileGenerator tests * Update SchemaModuleFileGenerator for ReferenceWrapped * Adapt ApolloCodegen to ReferenceWrapped and FileGenerator * fix: Test should match all rendered content * fix: remove equality implementation, will be synthesized instead
calvincestari
force-pushed
the
1.0/moduletype-none-filetemplates
branch
from
1607ece to
516e911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1 for #2034 - This refactor grew larger than I anticipated so I'm trying to limit the changesets and keep the PRs focused; this PR refactors the file templates to support
.nonemodule type..nonemodule type by wrapping the template in a namespace seemed simple enough until I got to having to split the header and import statements from the rest of the template body; that was complicated by each template handling the header/import statement additions.TemplateRenderer.TemplateRendereris a protocol that is responsible for combining individual templates based on the target of the template and the codegen configuration. Each individual template conforming to the protocol provides the base properties and the extension handles rendering and combining templates as needed.ReferenceWrapped. This allows us to pass around the codegen configuration struct internally without copying it each time it's passed to a new function.TemplateRendererandImportStatementTemplatetests for checking the import scenarios.Note: This PR will not pass CI checks until Part 2 is merged into it.