Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish support for .other module type #2195

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Conversation

calvincestari
Copy link
Member

PR 2 of 3 for #2034

This wraps up support for dependency managers that are not Swift Package Manager. The behaviour was already correct, the tests just needed a bit of refactoring and wider test coverage.

  • Removed the import statement tests from both fragment and operation template tests and instead created ImportStatementTemplateTests that bring wider test coverage.
  • Fixed a bug in the line-by-line comparison function that would invalidly pass tests when the expected value had more lines than the actual.

Base automatically changed from 1.0/schema-types-module-types to release/1.0 March 10, 2022 21:48
@calvincestari
Copy link
Member Author

@AnthonyMDev d0a677f relaxes the error condition from #2194 (comment).

@calvincestari calvincestari merged commit 137fe2b into release/1.0 Mar 10, 2022
@calvincestari calvincestari deleted the 1.0/moduletype-other branch March 10, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants