-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency manager support - CocoaPods #2185
Conversation
Moved away from multiple sub-generator structs that would need copies of config data to just use the data already in the enum with custom extensions.
let source: URL | ||
|
||
func render() -> String { | ||
TemplateString(""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the minimum required fields for a podspec, some of them we can autogenerate the content but most are really quite specific to the developer/organization/project and not something we can glean from the codegen configuration.
Right now these are stored as associated values with the .cocoapods
enum case of ModuleType. That means a larger configuration but does provide a lot of flexibility to the user. The podspec specification seems to be quite stable so I'm confident this isn't something we'll have to change often, if at all.
An alternative is to simply have a single freeform String
that the user must specify that is the 'guts' of the podspec but that opens a whole bunch of potential error scenarios where users have to consult the podspec documentation and then format it correctly - it's just not a good idea.
@AnthonyMDev would love your thoughts on this and whether you have alternative suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also isn't complete because the source_files
field has a bunch of variability to it which will need more associated values.
Closing this PR as we've settled on a different set of options. |
Some more detail on why this was closed - #2034 (comment). |
Relates to #2034
This adds support for the schema module, and operation files if co-located, to be exported as a CocoaPods Pod.
Right now the PR is a draft until I finalize how we let users specify details for the required podspec fields that we can't autogenerate.