Generate Operation Variables & Field Arguments #2163
Conversation
Finished implementation of operation variable generation
AnthonyMDev
force-pushed
the
1.0/operation-variables
branch
from
d3dd12e to
f9dcc92
Compare
…it object default values directly
AnthonyMDev
changed the title
|
@trevorblades Not sure why Netlify deploy preview is failing. Can you look at this? Netlify logs are showing |
Not sure why this happened, but I just re-ran the deploy and it seems to be working properly now. In the future, this kind of thing will be avoided since we'll only build docs deploy previews for PRs that change docs content. |
| @@ -34,6 +34,10 @@ public enum GraphQLEnum<T: EnumType>: CaseIterable, Equatable, RawRepresentable | |||
| self = .case(caseValue) | |||
| } | |||
|
|
|||
| public init(_ rawValue: String) { | |||
There was a problem hiding this comment.
Should we just make this the designated initializer signature instead of having two public methods that do the same thing?
There was a problem hiding this comment.
I might be misunderstanding you, but RawRepresentable requires you to have a public init(rawValue: String) initializer, so we can't do that.
| @@ -75,7 +75,7 @@ public class GraphQLInputField: JavaScriptObject { | |||
|
|
|||
| private(set) lazy var description: String? = self["description"] | |||
|
|
|||
| lazy var defaultValue: Any? = self["defaultValue"] | |||
| lazy var defaultValue: GraphQLValue? = (self["astNode"] as JavaScriptObject)["defaultValue"] | |||
There was a problem hiding this comment.
Haha thank you. This was painful to figure out... The other solution was going to require a lot of additional code in the TypeScript library that was going to further slow down the compilation of the AST. This is a little hacky, but definitely a better solution.
Long term, I'd really like us to re-write the JavascriptFrontend in Swift and just access the cold hard JavaScript objects in Swift directly from the start. It will be ugly and unsafe code, casting the JS objects directly without the TypeScript compiler checking and converting types for us, but it should improve performance further. Not urgent at all, but possibly a cool intern project or something haha. :)
No description provided.