Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codegen Swift script and AnimalKingdomAPI generated files #2144

Merged

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Feb 7, 2022

  1. Updates the Swift script for Codegen to accept a package manager command line parameter.
  2. Updates the generated Swift output for AnimalKingdomAPI

Note that the tag for the apollo-ios dependency in the AnimalKingdomAPI package is set to 1.0.0 which doesn't exist yet. Look to #2140 for an update that will correct the tag to one that will be released. If you want to validate that Package.swift is correct in this PR then update the apollo-ios dependency to the line below.

.package(url: "https://github.com/apollographql/apollo-ios.git", .branch("release/1.0-alpha-incubating")),

@calvincestari calvincestari added the codegen Issues related to or arising from code generation label Feb 7, 2022
@calvincestari calvincestari changed the base branch from release/1.0-alpha-incubating to 1.0/package-source-path February 7, 2022 20:42
@calvincestari calvincestari force-pushed the 1.0/updating-codegen-script branch 2 times, most recently from 6c64556 to 7baf1a5 Compare February 8, 2022 06:37
Base automatically changed from 1.0/package-source-path to release/1.0-alpha-incubating February 8, 2022 18:13
@calvincestari calvincestari force-pushed the 1.0/updating-codegen-script branch from 7baf1a5 to 704a74f Compare February 8, 2022 18:18
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement! Nice job!

@AnthonyMDev AnthonyMDev merged commit 7b15861 into release/1.0-alpha-incubating Feb 8, 2022
@AnthonyMDev AnthonyMDev deleted the 1.0/updating-codegen-script branch February 8, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen Issues related to or arising from code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants