Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionSet Template Rendering [4/X] #2124

Merged
merged 16 commits into from
Feb 1, 2022
Merged

SelectionSet Template Rendering [4/X] #2124

merged 16 commits into from
Feb 1, 2022

Conversation

AnthonyMDev
Copy link
Contributor

@AnthonyMDev AnthonyMDev commented Jan 31, 2022 •
edited
Loading

  • Renders TypeCase and Fragment Accessors
  • Renders nested entities for fields and type cases
  • Fixed some bugs in the string interpolation on TemplateString
    • Added new "section" interpolation to TemplateString
  • Boolean is now generated as "Bool"

@AnthonyMDev
Render Operation Definition
5cc9c86
@AnthonyMDev
Generation of Operation Definition 7 Clean up Swift Scripts
abb2b47
@AnthonyMDev
Added import ApolloAPI to templates
31e922b
@AnthonyMDev
Implement Fragment Template + File Generator
639b6ba 
And change ResponseDict to DataDict in template renderer
@AnthonyMDev
Calculate generatedSelectionSetName with merging from parent and type…
6b2a7e3 
… cases
@AnthonyMDev
WIP: TypeCase Accessors
3a748b6
@AnthonyMDev
fixed errors after rebasing
5dd8635
@AnthonyMDev
Move caching of generated seleciton set names to object retained by S…
b00279a 
…electionSetTemplate
@AnthonyMDev
Calculating TypeCase Merged names
fcc8889
@AnthonyMDev
Fixing TemplateString new line removal for sections
c524f3f
@AnthonyMDev
Render Fragment Container
a7324c1
@AnthonyMDev
Render Direct TypeCase SelectionSets
cc93abf
@AnthonyMDev
Regenerate AnimalKingdom API
2b3fb74
@AnthonyMDev
Render Boolean as "Bool"
f0f7fd0
@AnthonyMDev
Missing newline after field selections sets
4833ab3
@AnthonyMDev
Minor fix
e1dfc74
calvincestari
calvincestari approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AnthonyMDev AnthonyMDev merged commit dabe11e into release/1.0-alpha-incubating Feb 1, 2022
@AnthonyMDev AnthonyMDev deleted the 1.0/merged-source-parentAndTypeCase branch February 1, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyMDev @calvincestari