Dependency Automation - Swift Package Manager #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplates when we build them
4 tasks
calvincestari
commented
Jan 28, 2022
Sources/ApolloCodegenLib/Templates/SwiftPackageManagerModuleTemplate.swift
Outdated
Show resolved
Hide resolved
AnthonyMDev
requested changes
Jan 28, 2022
Sources/ApolloCodegenLib/FileGenerators/SchemaModuleFileGenerator.swift
Outdated
Show resolved
Hide resolved
Sources/ApolloCodegenLib/Templates/SwiftPackageManagerModuleTemplate.swift
Outdated
Show resolved
Hide resolved
Sources/ApolloCodegenLib/Templates/SwiftPackageManagerModuleTemplate.swift
Outdated
Show resolved
Hide resolved
| @@ -22,4 +22,16 @@ extension ApolloCodegenConfiguration { | |||
| apqs: apqs | |||
| ) | |||
| } | |||
|
|
|||
| public static func mock( | |||
There was a problem hiding this comment.
I added something similar in my most recent PR, so we should look and combine these after merging everything in.
AnthonyMDev
approved these changes
Jan 29, 2022
| .library(name: "\(moduleName)", targets: ["\(moduleName)"]), | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apollographql/apollo-ios.git", from: "1.0.0"), |
There was a problem hiding this comment.
Uh oh, this is a problem... we need to come up with a solution here to make sure we are just pulling in the same version as your project is using. Not sure what we can do about this.
There was a problem hiding this comment.
Oh maybe not? Because it's "from: 1.0.0" it will resolve with whatever version you are pulling in from your projects package file right?
There was a problem hiding this comment.
I believe so. It will be tricker in the alpha release as we discussed though because 1.0.0 won't be a tag yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Swift Package Manager dependency automation, generating an SPM manifest file.
The other three automation types (
.cocoapods,.carthageand.manuallyLinked) intentionally throw an exception.