Variables on GraphQLOperation - Refactor #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import Foundation | ||
|
|
||
| @dynamicMemberLookup | ||
| public enum GraphQLNullable<Wrapped>: ExpressibleByNilLiteral { |
There was a problem hiding this comment.
I saw there is already a reference to the documentation in InputValue.swift, is it worth linking to here too?
There was a problem hiding this comment.
Yeah will add a reference to docs here
| @@ -13,25 +13,32 @@ public protocol RequestBodyCreator { | |||
| /// - sendQueryDocument: Whether or not to send the full query document. Should default to `true`. | |||
| /// - autoPersistQuery: Whether to use auto-persisted query information. Should default to `false`. | |||
| /// - Returns: The created `GraphQLMap` | |||
There was a problem hiding this comment.
Suggested change
| /// - Returns: The created `GraphQLMap` | |
| /// - Returns: The created `JSONEncodableDictionary` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQLOptionaltoGraphQLNullableGraphQLMaptoJSONEncodableDictionaryGraphQLOperationmore strongly typed.