Make initializer for ApolloSchemaDownloadConfiguration.HTTPHeader public #1962
Conversation
|
@nsivertsen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Thanks so much for this fix @nsivertsen! Excited to merge this in once the CLA is signed! |
| } | ||
|
|
||
| /// How to download your schema. Supports the Apollo Registry and GraphQL Introspection methods. | ||
| let downloadMethod: DownloadMethod | ||
| public let downloadMethod: DownloadMethod |
There was a problem hiding this comment.
There's no reason to keep these private; once you've created the struct you should be able to inspect the property values.
There was a problem hiding this comment.
True for as long as they remain lets - If they're vars we may or may not want to allow direct access, although we could handle that with a private(set).
| @@ -1,9 +1,9 @@ | |||
| import XCTest | |||
| import ApolloTestSupport | |||
| import ApolloCodegenTestSupport | |||
| @testable import ApolloCodegenLib | |||
| import ApolloCodegenLib | |||
There was a problem hiding this comment.
Changed how this test imports ApolloCodegenLib to ensure public access is caught in further tests. The one test that relies on @testable is now separated.
Fixes #1961