-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen test updates #1877
Merged
calvincestari
merged 3 commits into
release/1.0-alpha-incubating
from
alpha-codegen-test-updates
Jul 21, 2021
Merged
Codegen test updates #1877
calvincestari
merged 3 commits into
release/1.0-alpha-incubating
from
alpha-codegen-test-updates
Jul 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designatednerd
approved these changes
Jul 20, 2021
AnthonyMDev
approved these changes
Jul 21, 2021
@@ -22,14 +21,13 @@ class ApolloCodegenTests: XCTestCase { | |||
super.tearDown() | |||
} | |||
|
|||
func testCreatingOptionsWithDefaultParameters() throws { | |||
func testDesignatedInitializer_givenRequiredParameters_shouldBuildDefaultArguments() throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this naming! :)
calvincestari
added a commit
that referenced
this pull request
Aug 13, 2021
* Add Swift codegen engine argument test * Update test function names to match #1849 * Remove test file attribution header
calvincestari
added a commit
that referenced
this pull request
Aug 23, 2021
* Add Swift codegen engine argument test * Update test function names to match #1849 * Remove test file attribution header
calvincestari
added a commit
that referenced
this pull request
Sep 3, 2021
* Add Swift codegen engine argument test * Update test function names to match #1849 * Remove test file attribution header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.swift
code generation engine argument