Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen test updates #1877

Merged

Conversation

calvincestari
Copy link
Member

  1. Add test for .swift code generation engine argument
  2. Update test function names to match Update tests to follow naming convention #1849

@calvincestari calvincestari added this to the MM-2021-07 milestone Jul 20, 2021
@@ -22,14 +21,13 @@ class ApolloCodegenTests: XCTestCase {
super.tearDown()
}

func testCreatingOptionsWithDefaultParameters() throws {
func testDesignatedInitializer_givenRequiredParameters_shouldBuildDefaultArguments() throws {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this naming! :)

@calvincestari calvincestari merged commit 3e768ed into release/1.0-alpha-incubating Jul 21, 2021
@calvincestari calvincestari deleted the alpha-codegen-test-updates branch July 21, 2021 18:27
@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
calvincestari added a commit that referenced this pull request Aug 13, 2021
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
calvincestari added a commit that referenced this pull request Aug 23, 2021
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
calvincestari added a commit that referenced this pull request Sep 3, 2021
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants