Networking Cleanup #1847
Networking Cleanup #1847
Conversation
AnthonyMDev
added
the
include-in-changelog
|
For the curious: This came out of an internal discussion about a bunch of stuff that was intended under prior plans that we've changed direction on, so we're renaming things to be more accurate for our current direction. |
| @@ -19,8 +19,6 @@ | |||
| 9B21FD782424305700998B5C /* ExpectedEnumWithDifferentCases.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9B68F05F2416F80C00E97318 /* ExpectedEnumWithDifferentCases.swift */; }; | |||
| 9B21FD792424305E00998B5C /* ExpectedEnumWithSanitizedCases.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9B68F063241703B200E97318 /* ExpectedEnumWithSanitizedCases.swift */; }; | |||
| 9B260BEB245A020300562176 /* ApolloInterceptor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9B260BEA245A020300562176 /* ApolloInterceptor.swift */; }; | |||
| 9B260BED245A021300562176 /* Parseable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9B260BEC245A021300562176 /* Parseable.swift */; }; | |||
| 9B260BEF245A022E00562176 /* FlexibleDecoder.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9B260BEE245A022E00562176 /* FlexibleDecoder.swift */; }; | |||
There was a problem hiding this comment.
goodbye, cockamamie idea for a generalizable parser, you were fun while you lasted
| public weak var delegate: WebSocketTransportDelegate? | ||
|
|
||
| let connectOnInit: Bool | ||
| let reconnect: Atomic<Bool> | ||
| var websocket: ApolloWebSocketClient | ||
| let websocket: ApolloWebSocketClient |
There was a problem hiding this comment.
boy I wish I could remember why this was a var in the first place...
| import Foundation | ||
|
|
||
| /// The default interceptor provider for typescript-generated code | ||
| open class DefaultInterceptorProvider: InterceptorProvider { |
There was a problem hiding this comment.
Since LegacyInterceptorProvider is something people have subclassed, do you think it's worth it to use @available deprecation stuff to get Xcode to offer a fix-it? Or is that overkill since we're in 0.x territory?
https://www.hackingwithswift.com/example-code/language/how-to-use-available-to-deprecate-old-apis
There was a problem hiding this comment.
Yeah, I think that's overkill since we're not at 1.0 yet.
|
|
||
| override class func setUp() { | ||
| super.setUp() | ||
| swap(&webSocketProvider, &WebSocketTransport.provider) |
Changelog Additions
LegacyInterceptorProvider->DefaultInterceptorProviderLegacyCacheReadInterceptor->CacheReadInterceptorLegacyCacheWriteInterceptor->CacheWriteInterceptorLegacyParsingInterceptor->JSONResponseParsingInterceptorWebSocketTransportis now initialized with anApolloWebSocket(or other object conforming to theApolloWebSocketClientprotocol.) Previously, the initializer took in the necessary parameters to create the web socket internally. This provides better dependency injection capabilities and makes testing easier.ApolloInterceptorand converted to structs for all interceptors that could be structs instead of classes.Note:
Before releasing, updates to docs need to go out. @AnthonyMDev has a stashed changeset where he started this. (Finish by running script generation and removing all instances of “Legacy”, "FlexibleDecoder", and "Parseable" left in docs!)