Allow different types of fetches on a watcher #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publicly exposing the fetch() function would allow us to make other kinds of fetches besides the `fetchIgnoringCacheData` exposed by `refetch()`. Our use case is that our custom version of `InMemoryNormalizedCache` has cache expiration, and we want to be able to hit the network only if the cache has become invalid. Alternately, we could manually check the cache, but this seems cleaner.
|
Thanks for the PR and explanation @gsbernstein. I think it might be cleaner to expose the cachePolicy as a parameter on |
|
In that case, should I just combine the fetch and refetch functions into a single |
|
Let's leave the private fetch function as is for now and just change the |
AnthonyMDev
approved these changes
Jun 15, 2021
|
Thanks for finishing this up! |
AnthonyMDev
added
the
include-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publicly exposing
GraphQLQueryWatcher's fetch() function would allow us to make other kinds of fetches besides thefetchIgnoringCacheDataexposed byrefetch(). Our use case is that our custom version ofInMemoryNormalizedCachehas cache expiration, and we want to be able to hit the network only if the cache has become invalid. Alternately, we could manually check the cache, but this seems cleaner.