-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Target Reconfiguration #1745
Test Target Reconfiguration #1745
Conversation
AnthonyMDev
commented
Apr 6, 2021
- Consolidates tests into targets for unit test, integration tests, performance test, and code gen tests.
- Moves integration test into new target that only runs on CI for easier local testing.
- Cleans up a few test
- Converts schemes to use XCTestPlans
- Configures CircleCI to use new test plans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty solid, just a couple of questions!
Approved from a content standpoint, obviously we have to figure out what's giving circle a sad. You may need to turn off XCPretty to get the full log barf, but i can't repro this locally either, so you may have to remote in to the running tests 😭 |
…IntegrationTests WIP on UnitTestPlan
…ut of RequestChainTests
20f3e0a
to
3f4932e
Compare
…tracting, and checking SHASUM