Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a workaround in the
jsonValue
property of Optional: the solution was to makeNSDictionary
conform toJSONEncodable
.Also fixed an issue where trying to serialize
.some(NSNull())
would result in a crash.BREAKING CHANGE (?): This slightly changes the result of the JSON serialization, because instead of taking a
NSDictionary
, casting toDictionary
and then callingjsonValue
on it, it directly uses theNSDictionary
as theJSONValue
itself.Previously, this resulted in having
Bool
values encoded asNSNumber
s, while now they are encoded as atrue
orfalse
JSON constants. IMHO, this is slightly more correct.