Add local upload server + tests #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designatednerd
commented
Aug 6, 2020
|
Ergh, I don't know what the hell is going on with Circle - running |
designatednerd
force-pushed
the
add/upload-tests
branch
from
68ca350 to
7275fe8
Compare
designatednerd
force-pushed
the
add/upload-tests
branch
from
1b9e7af to
0b2c9c7
Compare
designatednerd
force-pushed
the
add/upload-tests
branch
from
da9379d to
a9a9ea5
Compare
designatednerd
force-pushed
the
add/upload-tests
branch
from
a9a9ea5 to
7313634
Compare
designatednerd
force-pushed
the
add/upload-tests
branch
from
7313634 to
44e88aa
Compare
…to Star wars where appropriate
…using builds to freak out
still something borked
… can figure out what's going wrong
Circle, make me a sandwich
…permissions Totally not flinging things at the wall right now...
hwillson
force-pushed
the
add/upload-tests
branch
4 times, most recently
from
03befd3 to
34eefab
Compare
This will help ensure a consistent major version of Node is installed on each platform.
hwillson
force-pushed
the
add/upload-tests
branch
from
34eefab to
773a464
Compare
|
@hwillson is the 💣! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that in order to test something I'm trying to do with uploads in #1341, I need to actually test what we're already doing with uploads a lot more thoroughly.
In this PR:
UploadAPIframework that takes the schema from that server and makes requests with it.RequestCreatorTeststo actually use a real request that uses theUploadtypeUploadTeststo validate that requests succeed and the appropriate data is uploaded to the local server.NOTE: This is gonna be a draft until I can bribe @hwillson into helping me figure out how to add another mutation that has multiple parameters that accept an
Upload😇