Obsolete type GraphQLHTTPResponseError

[knox]

Bug report

With the new network stack (yeah!) a few types such as GraphQLHTTPResponseError became obsolte but did not get removed from code base yet.

Versions

• apollo-ios SDK version: 0.34.0

Steps to reproduce

"Find usages" of GraphQLHTTPResponseError, GraphQLHTTPRequestError and probably others.

[designatednerd]

GraphQLHTTPRequestError is still used, but good catch on the response error.

Please note that "find usages" isn't the be-all, end-all, especially for enum types - always worth doing a text search through the full codebase.

[knox]

The problem here for me was that by not beeing broken because of a removed class my validations got semantically broken because they where still checking for that type.

Of course you're right about GraphQLHTTPRequestError. I've mistaken that.

But still, regarding your advise to check for "usages" with full text search i have to strongly disagree. In fact i heavily rely on this kind of type based analysis and navigating through code and therefore i prefer AppCode over Xcode a lot because of it outstanding capabilities in that. You should give it a try.

[designatednerd]

I agree that it's helpful, but particularly when it comes to removing stuff, I've found it better to belt-and-suspenders things by actually searching out where something is used (even in AppCode, which I have used before).

[designatednerd]

This has been removed with 0.35.0. If you find other unused types, please open a new issue. Thanks!

[Max-Job]

how I can handle server error?

[knox]

Try something like this

        if case .invalidResponseCode(let response, _) = error as? ResponseCodeInterceptor.ResponseCodeError,
              let httpResponse = response {
            print(httpResponse.statusCode)
        }

[Max-Job]

@knox oh! thank you so much! it works for me)
but now I have another problem:
if environment (API URL) doesn't exist it's not working

[Max-Job]

if I write incorrect url here, I cannot handle error and get status code

let transport = RequestChainNetworkTransport(interceptorProvider: provider,
                                                     endpointURL: url)
        return ApolloClient(networkTransport: transport, store: store)

[designatednerd]

@Max-Job Could you please open this as a different issue and provide more details like:

• What type of error are you expecting to receive in this instance?
• What is the type of error which you do receive?