Fixed a data race that occasionally causes a crash if webSocketTransp…

…ort.closeConnection() and webSocketTransport.initServer() are called in succession. Fix was verified with Xcode Thread sanitizer
apollographql · Apr 1, 2021 · a45e61c · a45e61c
1 parent e2be065
commit a45e61c
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/Sources/ApolloWebSocket/WebSocketTransport.swift b/Sources/ApolloWebSocket/WebSocketTransport.swift
@@ -215,12 +215,13 @@ public class WebSocketTransport {
   }
 
   public func initServer() {
-    self.acked = false
+    processingQueue.async {
+      self.acked = false
 
-    if let str = OperationMessage(payload: self.connectingPayload, type: .connectionInit).rawMessage {
-      write(str, force:true)
+      if let str = OperationMessage(payload: self.connectingPayload, type: .connectionInit).rawMessage {
+        write(str, force:true)
+      }
     }
-
   }
 
   public func closeConnection() {