Remove stripping of null values from Selection Set models (apollograp…

…hql/apollo-ios-dev#25)
apollographql · Sep 5, 2023 · 18108c3 · 18108c3
1 parent 888461d
commit 18108c3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/Sources/Apollo/ApolloStore.swift b/Sources/Apollo/ApolloStore.swift
@@ -278,7 +278,6 @@ public class ApolloStore {
         withKey: key,
         variables: variables,
         accumulator: GraphQLSelectionSetMapper<SelectionSet>(
-          stripNullValues: false,
           handleMissingValues: .allowForOptionalFields
         )
       )

diff --git a/Sources/Apollo/GraphQLSelectionSetMapper.swift b/Sources/Apollo/GraphQLSelectionSetMapper.swift
@@ -7,7 +7,6 @@ final class GraphQLSelectionSetMapper<T: SelectionSet>: GraphQLResultAccumulator
 
   let requiresCacheKeyComputation: Bool = false
 
-  let stripNullValues: Bool
   let handleMissingValues: HandleMissingValues
 
   enum HandleMissingValues {
@@ -19,10 +18,8 @@ final class GraphQLSelectionSetMapper<T: SelectionSet>: GraphQLResultAccumulator
   }
 
   init(
-    stripNullValues: Bool = true,
     handleMissingValues: HandleMissingValues = .disallow
   ) {
-    self.stripNullValues = stripNullValues
     self.handleMissingValues = handleMissingValues
   }
 
@@ -48,7 +45,7 @@ final class GraphQLSelectionSetMapper<T: SelectionSet>: GraphQLResultAccumulator
   }
 
   func acceptNullValue(info: FieldExecutionInfo) -> AnyHashable? {
-    return stripNullValues ? nil : Optional<AnyHashable>.none
+    return DataDict.NullValue
   }
 
   func acceptMissingValue(info: FieldExecutionInfo) throws -> AnyHashable? {
@@ -89,3 +86,11 @@ final class GraphQLSelectionSetMapper<T: SelectionSet>: GraphQLResultAccumulator
     return T.init(_dataDict: rootValue)
   }
 }
+
+// MARK: - Null Value Definition
+extension DataDict {
+  /// A common value used to represent a null value in a `DataDict`.
+  ///
+  /// This value can be cast to `NSNull` and will bridge automatically.
+  static let NullValue = AnyHashable(Optional<AnyHashable>.none)
+}
diff --git a/Sources/ApolloAPI/DataDict.swift b/Sources/ApolloAPI/DataDict.swift
@@ -126,9 +126,7 @@ public struct DataDict: Hashable {
   }
 }
 
-
-
-// MARK: Value Conversion Helpers
+// MARK: - Value Conversion Helpers
 
 public protocol SelectionSetEntityValue {
   /// - Warning: This function is not supported for external use.

diff --git a/Tests/ApolloTests/GraphQLExecutor_SelectionSetMapper_FromResponse_Tests.swift b/Tests/ApolloTests/GraphQLExecutor_SelectionSetMapper_FromResponse_Tests.swift
@@ -23,7 +23,7 @@ class GraphQLExecutor_SelectionSetMapper_FromResponse_Tests: XCTestCase {
       selectionSet: selectionSet,
       on: object,      
       variables: variables,
-      accumulator: GraphQLSelectionSetMapper<T>(stripNullValues: true)
+      accumulator: GraphQLSelectionSetMapper<T>()
     )
   }