Fix crash when GraphQLError is “too many validation errors” #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a GraphQLError from the JS parsing step is a “Too many validation errors” error, there is no `source` in the error object. This was causing a crash. We should make this an optional parameter and check for it to avoid this edge case. Writing a unit test for this is difficult because we would need to write a large schema document with many errors in it. This is a minor edge case, and I think that an inline comment explaining the problem should suffice to prevent regressions here.
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
BobaFetters
pushed a commit
that referenced
this pull request
Jul 23, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jul 23, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jul 23, 2024
9c69435c Fix crash when GraphQLError is “too many validation errors” (#438) git-subtree-dir: apollo-ios-codegen git-subtree-split: 9c69435cd84ed7e40f221f9308e53e74c6df66ba
BobaFetters
pushed a commit
that referenced
this pull request
Jul 23, 2024
…“too many validation errors” git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 7673beb git-subtree-split: 9c69435cd84ed7e40f221f9308e53e74c6df66ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a GraphQLError from the JS parsing step is a “Too many validation errors” error, there is no
sourcein the error object. This was causing a crash. We should make this an optional parameter and check for it to avoid this edge case.Writing a unit test for this is difficult because we would need to write a large schema document with many errors in it. This is a minor edge case, and I think that an inline comment explaining the problem should suffice to prevent regressions here.