You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding the CI job to #367 I noticed that our CI uses older versions than what we use on our development machines and also older than what is available on GitHub.
This PR includes:
Update to use the latest macos image available instead of a static version
Update to use Xcode 15.4
Base automatically changed from
release/1.12.2 to
mainMay 23, 2024 20:00
@BobaFetters is there a way for us to force all CI jobs to run and not depend on the file tree changes? Looks like some are being skipped here but I'd prefer the confidence of having them all run.
@calvincestari Yea we can definitely do that, just need to determine the parameters of when we would want to do that vs what we do for most PRs. Like our release-check workflow always runs everything, so if we have something we can key off of in a PR like a specific title etc we could set it up pretty easy
@calvincestari Yea we can definitely do that, just need to determine the parameters of when we would want to do that vs what we do for most PRs. Like our release-check workflow always runs everything, so if we have something we can key off of in a PR like a specific title etc we could set it up pretty easy
Sounds good. I'll merge this and we can work on that on the side.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the CI job to #367 I noticed that our CI uses older versions than what we use on our development machines and also older than what is available on GitHub.
This PR includes: