Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update environment to latest versions #369

Merged
merged 2 commits into from
May 24, 2024

Conversation

calvincestari
Copy link
Member

When adding the CI job to #367 I noticed that our CI uses older versions than what we use on our development machines and also older than what is available on GitHub.

This PR includes:

  • Update to use the latest macos image available instead of a static version
  • Update to use Xcode 15.4

Base automatically changed from release/1.12.2 to main May 23, 2024 20:00
@calvincestari calvincestari force-pushed the chore/update-ci-environment branch from 4b9e9f8 to 33e4d16 Compare May 23, 2024 20:59
@calvincestari calvincestari marked this pull request as ready for review May 23, 2024 20:59
Copy link

netlify bot commented May 23, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 33e4d16
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/664fae30f745c600083dd03f

Copy link

netlify bot commented May 23, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 33e4d16
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/664fae305e5fe900083be427

@calvincestari
Copy link
Member Author

@BobaFetters is there a way for us to force all CI jobs to run and not depend on the file tree changes? Looks like some are being skipped here but I'd prefer the confidence of having them all run.

@BobaFetters
Copy link
Member

@calvincestari Yea we can definitely do that, just need to determine the parameters of when we would want to do that vs what we do for most PRs. Like our release-check workflow always runs everything, so if we have something we can key off of in a PR like a specific title etc we could set it up pretty easy

@calvincestari
Copy link
Member Author

@calvincestari Yea we can definitely do that, just need to determine the parameters of when we would want to do that vs what we do for most PRs. Like our release-check workflow always runs everything, so if we have something we can key off of in a PR like a specific title etc we could set it up pretty easy

Sounds good. I'll merge this and we can work on that on the side.

@calvincestari calvincestari merged commit 5900492 into main May 24, 2024
23 checks passed
@calvincestari calvincestari deleted the chore/update-ci-environment branch May 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants