Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Generated models support the @defer directive #31

Merged
merged 23 commits into from
Sep 26, 2023
Merged

feature: Generated models support the @defer directive #31

merged 23 commits into from
Sep 26, 2023

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Sep 11, 2023 •
edited
Loading

Closes apollographql/apollo-ios#3231

This is the new work to update the code generation engine to support @defer in generated models, which includes:

  • JS frontend
  • IR (lays the groundwork for the next phase of modifying the selection set templates)
  • Operation definition templates (for multipart request header)

@calvincestari calvincestari changed the base branch from main to feature/defer September 11, 2023 16:16
@calvincestari
Copy link
Member Author

calvincestari commented Sep 11, 2023 •
edited
Loading

Oops, this is meant to be a draft; still adding commits, tests to come next.
Tests done, now on to the codegen updates..

@calvincestari calvincestari marked this pull request as draft September 11, 2023 16:17
@calvincestari calvincestari force-pushed the defer/generated-models branch 2 times, most recently from 2852be5 to 6b5cf40 Compare September 13, 2023 21:34
@calvincestari calvincestari force-pushed the defer/generated-models branch 2 times, most recently from 622977a to 17a1571 Compare September 19, 2023 20:55
calvincestari and others added 20 commits September 22, 2023 11:52
@calvincestari
Added supporting changes for deferred fragments
0a4e0db
@calvincestari
Add tests to validate deferred inline fragment
3b6543a
@calvincestari
Add tests to validate deferred named fragment
f14ee8b
@calvincestari
Another test
123d98a
@calvincestari
Add nested deferred inline fragment test
83dba17
@calvincestari
Label is no longer required for named fragments
0cc1391
@calvincestari
Added documentation
14ba7d3
@calvincestari @AnthonyMDev
Update Tests/ApolloCodegenTests/CodeGeneration/Templates/SelectionSet…
d4afea7 
…/SelectionSetTemplateTests.swift

Co-authored-by: Anthony Miller <[email protected]>
@calvincestari @AnthonyMDev
Update Tests/ApolloCodegenTests/CodeGeneration/Templates/SelectionSet…
ec4643a 
…/SelectionSetTemplateTests.swift

Co-authored-by: Anthony Miller <[email protected]>
@calvincestari
Fixed tests
0e7c48b
@calvincestari
Remove isDeferred from ScopeCondition
1df8903
@calvincestari
Add deferred collection to ScopeDescriptor
57f5b0b
@calvincestari
Fix test mocks
42d5191
@calvincestari
Update operation template for deferred property
ff9d579
@calvincestari
Refactor for deferred named fragment spreads
1adb93d
@calvincestari
Combine deferred properties of IR built named fragments into operation
9b1808d
@calvincestari
Refactor scope descriptor evaluation
9e7416e
@calvincestari
Add inline documentation
7bc5f32
@calvincestari
Remove selection set template defer tests
d8c4ad8
@calvincestari
Updated JS frontend bundle
14559fd
calvincestari
calvincestari commented Sep 22, 2023
View reviewed changes
apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/src/__tests__/referencedFragmentsTests.ts
@@ -25,8 +25,7 @@ describe("operation with referencedFragments", () => {
...FragmentA
...FragmentC
}
`, "OperationA", { line: 1, column: 1 }),
false
`, "OperationA", { line: 1, column: 1 })
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to the move from graphql-js 16 to 17.

@calvincestari calvincestari marked this pull request as ready for review September 22, 2023 21:48
@calvincestari calvincestari linked an issue Sep 26, 2023 that may be closed by this pull request
Modify operation definition to support multipart response requests apollographql/apollo-ios#3231
Closed
@calvincestari calvincestari merged commit 3fbe180 into feature/defer Sep 26, 2023
@calvincestari calvincestari deleted the defer/generated-models branch September 26, 2023 19:38
BobaFetters pushed a commit that referenced this pull request Nov 2, 2023
Squashed 'apollo-ios/' changes from eff46e4..9759ba2
68c86f1 
9759ba2 merge:  branch into  (#121)
d5c6b1f 2023-11-02 Roadmap update
5cc8f75 Merge branch 'main' into feature/defer
98dfa68 merge: `feature/defer` update to `main` (#116)
1a7bde4 Merge branch 'main' into feature/defer
60d4dc4 Merge branch 'main' into feature/defer
773b890 Merge branch 'main' into feature/defer
b574fbc Merge branch 'main' into feature/defer
72306f7 feature: Operation definition template supports the `@defer` directive (#31)
98c06c6 Merge branch 'project-breakup' into feature/defer
febc191 rfc: Clarifying edits (#22)
0b563c9 Migrating defer branch to new project structure

git-subtree-dir: apollo-ios
git-subtree-split: 9759ba2
BobaFetters pushed a commit that referenced this pull request Nov 2, 2023
Squashed 'apollo-ios-codegen/' changes from 80c4d42e..f499efa4
68d78db 
f499efa4 chore: Disable `@defer` support (#122)
70fd68cd Merge branch 'main' into feature/defer
d6c49617 Defer Selection Set Template - Basic (W/clean up) (#118)
f5dc1758 merge: `feature/defer` update to `main` (#116)
2c5463b0 refactor: [1/x] Refactor root field builder for deferred fragments (#74)
25d44b83 Merge branch 'main' into feature/defer
1d8424d3 Merge branch 'main' into feature/defer
a8c31ca3 Merge branch 'main' into feature/defer
d1a3c0ab feature: Operation definition template supports the `@defer` directive (#31)
6a01891b Merge branch 'project-breakup' into feature/defer
11cf5828 Merge branch 'project-breakup' into feature/defer
723b8648 refactor: Don't require `label` argument for deferred named fragments (#33)
9041eee0 feature: Require `label` argument on `@defer` directive (#28)
01b81541 Migrating defer branch to new project structure

git-subtree-dir: apollo-ios-codegen
git-subtree-split: f499efa4ee99c7eb86e5f2e6d0b630756c48f0de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify operation definition to support multipart response requests
2 participants
@calvincestari @AnthonyMDev