Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Expand test suite for multipart subscriptions #287

Merged

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Mar 8, 2024

@calvincestari calvincestari marked this pull request as ready for review March 8, 2024 21:10
@calvincestari calvincestari requested a review from a team as a code owner March 8, 2024 21:10
@calvincestari
Copy link
Member Author

@AnthonyMDev, this PR is ready for review. There are failing tests in the 'Codegen Test Configurations' job but that's failing due to warnings about unused variables. This PR is fine to merge with those because it's merging into feature/defer-execution-networking and those warnings are fixed in #217 which also merges into feature/defer-execution-networking. So once this PR is merged I'll rebase the branch for #217.

Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question on a few tests!

@calvincestari calvincestari merged commit 8bc9df5 into feature/defer-execution-networking Mar 12, 2024
15 of 16 checks passed
@calvincestari calvincestari deleted the router-multipart-update branch March 12, 2024 22:52
@calvincestari
Copy link
Member Author

There are failing tests in the 'Codegen Test Configurations' job but that's failing due to warnings about unused variables. This PR is fine to merge with those because it's merging into feature/defer-execution-networking and those warnings are fixed in #217 which also merges into feature/defer-execution-networking. So once this PR is merged I'll rebase the branch for #217.

As mentioned before re. the failing tests - once this PR was merged I then merged feature/defer-execution-networking into defer/partial-and-incremental-execution and the test suite passes as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants