Import statements update (w/tests) #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…renced Fragment includes an import directive
…les in definitions + do not assing to the definitions directives anymore
…les in definitions + do not assing to the definitions directives anymore
…les in definitions + do not assing to the definitions directives anymore
…les in definitions + do not assing to the definitions directives anymore
…les in definitions + do not assing to the definitions directives anymore
…les in definitions + do not assing to the definitions directives anymore
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
calvincestari
approved these changes
Jan 24, 2024
| ) -> TemplateString? { | ||
| guard let moduleImports else { return nil } | ||
| moduleImports: OrderedSet<String> | ||
| ) -> TemplateString { | ||
| return """ | ||
| \(moduleImports.map { "import \($0)" }.joined(separator: "\n")) |
There was a problem hiding this comment.
Should we have a comment above these to identify these as custom configured imports?
| // given | ||
| let config = buildConfig( | ||
| moduleType: | ||
| .embeddedInTarget( |
There was a problem hiding this comment.
It looks as though the custom imports should be rendered regardless of the moduleType configuration - it might be worth having additional tests for the other module types to ensure that remains true.
BobaFetters
pushed a commit
that referenced
this pull request
Jan 25, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jan 25, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jan 25, 2024
0ca66206 Import statements update (w/tests) (#245) git-subtree-dir: apollo-ios-codegen git-subtree-split: 0ca66206e6e9720f59141bf1fce422277507013b
BobaFetters
pushed a commit
that referenced
this pull request
Jan 25, 2024
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 5da6e8d git-subtree-split: 0ca66206e6e9720f59141bf1fce422277507013b
|
@AnthonyMDev Do you have an eta for the next release by any chance with this change included? |
|
Hi @hemel - I think we can probably put together a release tomorrow; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #236 that includes unit tests. The next step will be adding documentation to this before we release it.
Thanks @hemel for your helping getting this completed!