feature(defer): Code generation #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
commented
Jan 5, 2024
| @@ -538,13 +568,22 @@ struct SelectionSetTemplate { | |||
| let isOptional = | |||
| fragment.inclusionConditions != nil | |||
| && !scope.matches(fragment.inclusionConditions.unsafelyUnwrapped) | |||
| let isDeferred = fragment.typeInfo.deferCondition != nil | |||
|
|
|||
| return """ | |||
There was a problem hiding this comment.
I think we might be at the point where it makes sense to break this function into smaller focused functions.
calvincestari
commented
Jan 5, 2024
| @@ -18,7 +18,7 @@ public class NamedFragmentSpread: Hashable, CustomDebugStringConvertible { | |||
| /// Indicates the location where the fragment has been "spread into" its enclosing | |||
| /// operation/fragment. It's `scopePath` and `entity` reference are scoped to the operation it | |||
| /// belongs to. | |||
| let typeInfo: SelectionSet.TypeInfo | |||
| public let typeInfo: SelectionSet.TypeInfo | |||
There was a problem hiding this comment.
Is there any reason this shouldn't be a public constant? Doing so matches what we make available on InlineFragment and means we don't need to have a public method just to get at deferCondition. The type info is also used in the deferred fragment metadata template, but that may change.
calvincestari
commented
Jan 5, 2024
calvincestari
force-pushed
the
defer/oustanding-defer-codegen
branch
from
a5fa3e9 to
58a7894
Compare
|
Be sure to handle these two items in this PR too: |
Base automatically changed from
defer/partial-and-incremental-execution
to
feature/defer-execution-networking
March 19, 2024 23:30
…ing-defer-codegen # Conflicts: # Tests/ApolloCodegenTests/CodeGenIR/IRRootFieldBuilderTests.swift # Tests/ApolloTests/GraphQLResultTests.swift # Tests/ApolloTests/Interceptors/IncrementalJSONResponseParsingInterceptorTests.swift # Tests/ApolloTests/Interceptors/MultipartResponseDeferParserTests.swift # apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/SelectionSetTemplate.swift # apollo-ios/Sources/Apollo/AnyGraphQLResponse.swift # apollo-ios/Sources/Apollo/GraphQLResult.swift # apollo-ios/Sources/Apollo/IncrementalGraphQLResponse.swift # apollo-ios/Sources/Apollo/IncrementalJSONResponseParsingInterceptor.swift # apollo-ios/Sources/Apollo/MultipartResponseDeferParser.swift # apollo-ios/Sources/ApolloAPI/GraphQLOperation.swift
This was referenced Apr 4, 2024
|
Closing this as the work has been split into PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing pieces to codegen for the
@deferimplementation:@deferon a named fragment - the template changes in this draft PR at the moment only solve for simple named fragment use cases in order to ready for a preview release. As I add the test cases I'll resolve for all use cases of deferred named fragments.There are no tests included with this PR yet, they're still coming