feat(apollo-ios-codegen): Stable sort schema types for SchemaMetadata (…

…#514)
apollographql · Oct 21, 2024 · d336f36 · d336f36
1 parent 134147b
commit d336f36
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Tests/ApolloCodegenTests/CodeGenIR/IRInputObjectTests.swift b/Tests/ApolloCodegenTests/CodeGenIR/IRInputObjectTests.swift
@@ -25,7 +25,7 @@ class IRInputObjectTests: XCTestCase {
 
   func buildSubject() async throws {
     let ir: IRBuilder = try await .mock(schema: schemaSDL, document: document)
-    subject = ir.schema.referencedTypes.inputObjects.first!
+    subject = ir.schema.referencedTypes.inputObjects[1]
   }
 
   // MARK: - Tests

diff --git a/apollo-ios-codegen/Sources/IR/IR+Schema.swift b/apollo-ios-codegen/Sources/IR/IR+Schema.swift
@@ -33,7 +33,8 @@ public final class Schema {
       _ types: [GraphQLNamedType],
       schemaRootTypes: CompilationResult.RootTypeDefinition
     ) {
-      self.allTypes = OrderedSet(types)
+      // Ensure allTypes is stable
+      self.allTypes = OrderedSet(types.sorted(by: { $0.name.schemaName < $1.name.schemaName }))
       self.schemaRootTypes = schemaRootTypes
 
       var objects = OrderedSet<GraphQLObjectType>()