Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Instruct TS that reading from cache could sometime give null #2572

Merged
merged 3 commits into from
Nov 16, 2017

Conversation

kamilkisiela
Copy link
Contributor

Fixes #2503

@apollo-cla
Copy link

apollo-cla commented Nov 15, 2017

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Messages
📖

Please add your name and email to the AUTHORS file (optional)

Generated by 🚫 dangerJS

@kamilkisiela
Copy link
Contributor Author

@jbaxleyiii I'm pretty sure it won't break any library or any app that uses apollo-client or apollo-cache but I haven't checked it. That's why I marked it as WIP and in-progress but feel free to merge it.

@jbaxleyiii
Copy link
Contributor

@nevir @yuit will this break hermes (I'd assume so?)

@nevir
Copy link
Contributor

nevir commented Nov 16, 2017

Probably! But a worthy change 👍 No prob

@jbaxleyiii jbaxleyiii merged commit d87b1bc into master Nov 16, 2017
@jbaxleyiii jbaxleyiii deleted the fix-2503 branch November 16, 2017 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants