Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal error messages more helpful #174

Closed
stubailo opened this issue May 4, 2016 · 2 comments
Closed

Make internal error messages more helpful #174

stubailo opened this issue May 4, 2016 · 2 comments

Comments

@stubailo
Copy link
Contributor

stubailo commented May 4, 2016

This is a good idea overall - we should try to write tests for adverse situations and make sure we print good errors in those cases. Various invalid GraphQL responses, etc.

@deoqc
Copy link

deoqc commented May 20, 2016

When I passed the wrong type to a mutation it failed silently. Easy and useful case for good error message.

mutation: gql`
  mutation onAwesomeMutation($quantity: String!) { # <--- should be Int!
    awesomeMutation (quantity: $quantity)
  }
 `,

@helfer
Copy link
Contributor

helfer commented Mar 28, 2017

I think this issue is too general. It will be much easier to solve these as they come along. Every time someone files an issue we should follow a process in which we do the following:

  • Identify the root cause
  • Fix the bug/issue
  • Write a test for the bug/issue. Make sure to refer to the github issue in the test comments.
  • Think about how we can prevent similar issues from even coming up in the future.

In essence when an issue comes up we shouldn't just fix that issue, but also prevent similar issues from occurring again in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants