Be more tolerant of errors triggered by store reset #1538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client is disconnected from devtools, commonly because of a page refresh, we clear the data in the devtools client to start with fresh data via
client.clearStore()
. This triggered some race conditions where a fetch could have started as a result of a poll on a particular tab and thus the error page would be displayed.This PR makes the devtools more tolerant of errors related to store resets so that we can continue polling for data.
Fixes #1524
This also attempts to fix #1524 by using optional chaining when accessing
clientErrors
andprotocolErrors
when serializing errors.