Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Output webpack-stats.json using webpack-stats-plugin #1529

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

vio
Copy link
Contributor

@vio vio commented Sep 21, 2024

Output webpack-stats.json for a single configuration. The webpack-cli json output for multiple configurations is not supported.

before:

Send stats to RelativeCI branch=renovate/peter-evans-create-pull-request-7.x commit=4ccc00b79d3140a0adb54af3670f72ecf7e0c02e
{
  code: 'BadRequest',
  message: 'Invalid webpack stats structure, please make sure webpack stats configuration is correct.\n' +
    '\n' +
    'Expected a nonempty array but received an empty one\n' +
    'Path: assets\n' +
    'Failed structure(assets): []'

after:

Send stats to RelativeCI branch=fix-webpack-stats-output commit=c4fa1d96824e7c584374276372c574817d2a5148
Job #2 done.
Bundle Size — 1.6MiB (+100%).

@vio vio requested a review from a team as a code owner September 21, 2024 17:24
@apollo-cla
Copy link

@vio: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@vio vio force-pushed the fix-webpack-stats-output branch from c4fa1d9 to daeed1b Compare September 21, 2024 17:27
Copy link

pkg-pr-new bot commented Sep 23, 2024

npm i https://pkg.pr.new/apollographql/apollo-client-devtools/@apollo/client-devtools-vscode@1529

commit: daeed1b

Copy link

relativeci bot commented Sep 23, 2024

#880 Bundle Size — 1.6MiB (+5.87%).

daeed1b(current) vs 6a4bf24 main#879(baseline)

Warning

Bundle contains 13 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 1 regression
                 Current
#880
     Baseline
#879
Regression  Initial JS 1.47MiB(+0.03%) 1.47MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 96.88% 0%
No change  Chunks 5 5
Change  Assets 144(+1100%) 12
Change  Modules 1219(+0.08%) 1218
No change  Duplicate Modules 45 45
Change  Duplicate Code 3.13%(+0.32%) 3.12%
No change  Packages 183 183
No change  Duplicate Packages 10 10
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#880
     Baseline
#879
Regression  JS 1.47MiB (+0.03%) 1.47MiB
Regression  Other 91.15KiB (+12230.52%) 757B
No change  IMG 35.85KiB 35.85KiB
No change  HTML 857B 857B

Bundle analysis reportBranch vio:fix-webpack-stats-outputProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for fixing that!

@phryneas phryneas merged commit 5a75c41 into apollographql:main Sep 23, 2024
10 of 11 checks passed
@vio vio deleted the fix-webpack-stats-output branch September 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants