Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent renovate from upgrading all-clients packages #1296

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Prevent renovate from upgrading all-clients packages #1296

merged 2 commits into from
Mar 21, 2024

Conversation

jerelmiller
Copy link
Member

No description provided.

@jerelmiller jerelmiller requested a review from a team as a code owner March 21, 2024 17:02
alessbell
alessbell approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one more bad change snuck in with #1294, lgtm

@jerelmiller
Copy link
Member Author

Curse you renovate! Haha. I closed that one and renovate said "f it" and merged anyways

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 21, 2024 •
edited
Loading

Job #109: Bundle Size — 1.13MiB (0%).

1d38e6c(current) vs ff474cf main#107(baseline)

Warning

Bundle contains 5 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #109		      Baseline
Job #107
No change  Initial JS 1.09MiB 1.09MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 5 5
No change  Assets 12 12
No change  Modules 514 514
No change  Duplicate Modules 52 52
No change  Duplicate Code 8.17% 8.17%
No change  Packages 60 60
No change  Duplicate Packages 4 4
Bundle size by type  no changes
                 Current
Job #109		      Baseline
Job #107
Not changed  JS 1.09MiB 1.09MiB
Not changed  IMG 35.85KiB 35.85KiB
Not changed  HTML 810B 810B
Not changed  Other 777B 777B

View job #109 report View revert-change branch activity View project dashboard

@alessbell
Copy link
Contributor

I closed that one and renovate said "f it" and merged anyways

I saw that happen in real time 😭

@phryneas
Copy link
Member

I mean realistically it doesn't matter too much what happens with that package.json as it will just be recreated the next time we trigger the workflow

@jerelmiller jerelmiller merged commit beb5496 into main Mar 21, 2024
9 checks passed
@jerelmiller jerelmiller deleted the revert-change branch March 21, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessbell alessbell alessbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerelmiller @alessbell @phryneas