-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully fix issue sending data from client to devtools #1268
Conversation
Job #8: Bundle Size — 1.08MiB (~-0.01%).Warning Bundle contains 5 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #8 report View json-stringify-all-data branch activity View project dashboard |
a63ea5a
to
1147da9
Compare
Noting here that @phryneas had a good idea to |
1147da9
to
92fb43e
Compare
// sent without errors. | ||
// | ||
// https://github.com/apollographql/apollo-client-devtools/issues/1258 | ||
payload: JSON.parse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll note here that I think a potential future improvement here is to catch errors in case the cache can't be fully stringified. It would be a much nicer experience to show an error in the devtools panel, but we'll need to figure out a way to transport that error over. That is a bit out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Chrome, TypeScript compiles, looks good, let's go! :)
Fully reverts changes from #1245 that removed
JSON.stringify
from the entire client payload. Irregular cache values caused some issues when serializing on all fields.