Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize find items interface #605

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Apr 28, 2017

No description provided.

@lepdou lepdou force-pushed the optimize-finditems branch from bc9f530 to eaa602b Compare April 28, 2017 09:47
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling eaa602b21367fdae2cd7c01ef1cd6905176e5565 on lepdou:optimize-finditems into ** on ctripcorp:master**.

@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #605 into master will decrease coverage by 0.06%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #605      +/-   ##
============================================
- Coverage     46.57%   46.51%   -0.07%     
+ Complexity     1454     1453       -1     
============================================
  Files           339      339              
  Lines          9241     9249       +8     
  Branches        911      913       +2     
============================================
- Hits           4304     4302       -2     
- Misses         4611     4621      +10     
  Partials        326      326
Impacted Files Coverage Δ Complexity Δ
...p/framework/apollo/biz/service/ReleaseService.java 81.18% <100%> (ø) 41 <2> (ø) ⬇️
...apollo/adminservice/controller/ItemController.java 3.12% <100%> (ø) 2 <1> (ø) ⬇️
...apollo/adminservice/aop/NamespaceUnlockAspect.java 59.57% <100%> (-4.26%) 12 <0> (-1)
...trip/framework/apollo/biz/service/ItemService.java 8.57% <44.44%> (-1.11%) 4 <2> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e377c...9670f6e. Read the comment docs.

@lepdou lepdou force-pushed the optimize-finditems branch from eaa602b to 9670f6e Compare April 28, 2017 09:52
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9670f6e on lepdou:optimize-finditems into ** on ctripcorp:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9670f6e on lepdou:optimize-finditems into ** on ctripcorp:master**.

@nobodyiam nobodyiam merged commit bd1832b into apolloconfig:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants