Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Role**Service to interface impl #604

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

timothynode
Copy link

change RoleInitializationService and RolePermissionService to interface implement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 50.114% when pulling 529343d8b3877387ea17266a1c2b4639afe46972 on timothynode:master into bc0e484 on ctripcorp:master.

@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #604 into master will increase coverage by <.01%.
The diff coverage is 92.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #604      +/-   ##
============================================
+ Coverage     46.55%   46.56%   +<.01%     
- Complexity     1451     1453       +2     
============================================
  Files           338      339       +1     
  Lines          9238     9241       +3     
  Branches        911      911              
============================================
+ Hits           4301     4303       +2     
  Misses         4611     4611              
- Partials        326      327       +1
Impacted Files Coverage Δ Complexity Δ
...lo/portal/spi/configuration/AuthConfiguration.java 10% <ø> (ø) 1 <0> (ø) ⬇️
.../defaultimpl/DefaultRoleInitializationService.java 100% <100%> (ø) 11 <11> (?)
...lo/portal/spi/configuration/RoleConfiguration.java 100% <100%> (ø) 3 <3> (?)
.../spi/defaultimpl/DefaultRolePermissionService.java 87.77% <87.77%> (ø) 24 <24> (?)
.../apollo/internals/RemoteConfigLongPollService.java 80.28% <0%> (-0.71%) 22% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0e484...701a384. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 50.114% when pulling 701a384 on timothynode:master into bc0e484 on ctripcorp:master.

@lepdou lepdou merged commit 14ccb66 into apolloconfig:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants