Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app's admin can create private namespace. & default create namespace … #553

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Feb 28, 2017

…when create public appnamespace

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 49.787% when pulling ca649c0b101fe2797ecf03b08aab5140f91e0930 on lepdou:private_namespace into 12a0073 on ctripcorp:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 49.787% when pulling ca649c0b101fe2797ecf03b08aab5140f91e0930 on lepdou:private_namespace into 12a0073 on ctripcorp:master.

@codecov-io
Copy link

Codecov Report

Merging #553 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #553      +/-   ##
============================================
+ Coverage     46.44%   46.45%   +0.01%     
+ Complexity     1349     1348       -1     
============================================
  Files           322      322              
  Lines          8708     8703       -5     
  Branches        832      829       -3     
============================================
- Hits           4044     4043       -1     
+ Misses         4375     4371       -4     
  Partials        289      289
Impacted Files Coverage Δ Complexity Δ
.../apollo/portal/controller/NamespaceController.java 3.84% <ø> (ø) 2 <0> (ø)
...k/apollo/portal/component/PermissionValidator.java 8.33% <ø> (+2.08%) 1 <0> (ø)
...ork/apollo/biz/service/NamespaceBranchService.java 65.88% <0%> (ø) 11 <0> (ø)
...llo/adminservice/controller/ClusterController.java 12.5% <0%> (ø) 2 <0> (ø)
...p/framework/apollo/biz/service/ClusterService.java 51.85% <0%> (ø) 9 <0> (ø)
...framework/apollo/biz/service/NamespaceService.java 62.26% <100%> (ø) 32 <2> (ø)
...ork/apollo/portal/service/AppNamespaceService.java 92.59% <100%> (-0.27%) 11 <0> (-1)
...rip/framework/apollo/biz/service/AdminService.java 100% <100%> (ø) 2 <0> (ø)
...mework/apollo/biz/service/AppNamespaceService.java 29.82% <33.33%> (ø) 5 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a0073...ca649c0. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

Merging #553 into master will decrease coverage by -0.08%.
The diff coverage is 13.33%.

@@             Coverage Diff              @@
##             master     #553      +/-   ##
============================================
- Coverage     46.44%   46.36%   -0.08%     
- Complexity     1349     1350       +1     
============================================
  Files           322      324       +2     
  Lines          8708     8725      +17     
  Branches        832      831       -1     
============================================
+ Hits           4044     4045       +1     
- Misses         4375     4392      +17     
+ Partials        289      288       -1
Impacted Files Coverage Δ Complexity Δ
...p/framework/apollo/biz/service/ClusterService.java 51.85% <0%> (ø) 9 <0> (ø)
.../apollo/portal/controller/NamespaceController.java 3.57% <0%> (-0.28%) 2 <0> (ø)
...k/apollo/portal/component/PermissionValidator.java 6.25% <0%> (ø) 1 <0> (ø)
...framework/apollo/portal/entity/vo/PageSetting.java 0% <0%> (ø) 0 <0> (?)
...k/apollo/portal/component/config/PortalConfig.java 22.58% <0%> (-0.76%) 8 <0> (ø)
...ork/apollo/biz/service/NamespaceBranchService.java 65.88% <0%> (ø) 11 <0> (ø)
...llo/adminservice/controller/ClusterController.java 12.5% <0%> (ø) 2 <0> (ø)
...framework/apollo/biz/service/NamespaceService.java 62.26% <100%> (ø) 32 <2> (ø)
...ork/apollo/portal/service/AppNamespaceService.java 92.59% <100%> (-0.27%) 11 <0> (-1)
...rip/framework/apollo/biz/service/AdminService.java 100% <100%> (ø) 2 <0> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a0073...cd55a0d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 49.673% when pulling 57ab79da64cd68cf75587fb5c889903c256ed97a on lepdou:private_namespace into 12a0073 on ctripcorp:master.

@nobodyiam nobodyiam merged commit 6015c75 into apolloconfig:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants